Re: [PATCH] fast-import: use binary search in tree_content_remove
- Date: Sun, 11 Mar 2007 12:54:32 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] fast-import: use binary search in tree_content_remove
On Sun, Mar 11, 2007 at 12:34:13PM -0400, Jeff King wrote: > > I'm plastering over the problem by resorting a tree strictly by > > name after it has been written out and the deleted entries have > > been filtered out. > I wonder if we could make this a bit cleaner by actually using the git > sort in the first place. I will take a look... Hrm, it's not that hard to pass the mode around and use base_name_compare, but I don't think that's enough. Any time we turn an entry into a tree, we'll have to resort. I think your patch is simpler and less error prone. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
- Follow-Ups:
- Re: [PATCH] fast-import: use binary search in tree_content_remove
- From: Shawn O. Pearce
- Re: [PATCH] fast-import: use binary search in tree_content_remove
- References:
- [PATCH 0/3] fast-import slow on large directories
- From: Jeff King
- [PATCH 3/3] fast-import: improve efficiency of tree_content_set
- From: Jeff King
- Re: [PATCH 3/3] fast-import: improve efficiency of tree_content_set
- From: Jeff King
- [PATCH] fast-import: use binary search in tree_content_remove
- From: Jeff King
- Re: [PATCH] fast-import: use binary search in tree_content_remove
- From: Shawn O. Pearce
- Re: [PATCH] fast-import: use binary search in tree_content_remove
- From: Jeff King
- [PATCH 0/3] fast-import slow on large directories
- Prev by Date: Re: [PATCH] fast-import: use binary search in tree_content_remove
- Next by Date: Re: How to use git-svnimport without trunk, tags and branches?
- Previous by thread: Re: [PATCH] fast-import: use binary search in tree_content_remove
- Next by thread: Re: [PATCH] fast-import: use binary search in tree_content_remove
- Index(es):