Re: [PATCH v2] Add support for GIT_CEILING_DIRS

[Johannes Schindelin <Johannes.Schindelin@xxxxxx>]

Hi,

On Thu, 15 May 2008, Johannes Sixt wrote:

> +		do { } while (offset > ceil_offset && cwd[--offset] != '/');

You probably meant to remove the "do { }", and have an own line

			; /* do nothing */

but for the rest, I agree that it is easier on the eye (particularly the 
off-by-one issue, which is always a problem for this developer to get 
right; avoiding it is therefore the better option).

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html