Re: [PATCH v3] Add support for GIT_CEILING_DIRS

[Johannes Schindelin <Johannes.Schindelin@xxxxxx>]

Hi,

On Thu, 15 May 2008, Junio C Hamano wrote:

> David Reiss <dreiss@xxxxxxxxxxxx> writes:
> 
> > + * ....  Paths must
> > + * be in a canonical form: empty components, or "." or ".." components
> > + * are not allowed.  prefix_list may be null, which is like "".
> 
> The caller starts from cwd[] and chomps, so you can safely assume that 
> it would not feed anything problematic.  But prefix_list comes from 
> user's environment, and it is easy to make mistakes like doubled slashes 
> (which you seem to take care) and also is tempting to use ".." when 
> specifying the ceiling (e.g. "CEIL=$HOME/..").  Perhaps canonicalizing 
> the ceiling would make this easier to use for end users?

Is this not going too far?  I mean, CEILING_DIRECTORIES is already a very 
special case.

> How well would this colon separated list work with msys folks?

Not well at all.  At least for the moment, I think setting this variable 
would fail (since it would be rewritten into a Windows-PATH-style string).  
Though honestly, I have no idea what getcwd() does on MinGW.

Steffen is working on that rewriting stuff, so maybe it will be a 
non-issue, eventually.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html