Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- Date: Fri, 16 May 2008 17:06:13 -0700
- From: Tommy Thorn <tommy-git@xxxxxxxx>
- Subject: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
Johannes Schindelin wrote:
+/*
+ * This is an ugly hack to avoid fgetc(), which is slow, as it is locking.
+ * The argument "in" must be the same for all calls to this function!
+ */
+static int fast_fgetc(FILE *in)
+{
Looks great to me, but shouldn't you add an "inline" for this one? Also, maybe a double the buffer size.
Tommy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
- Follow-Ups:
- Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- From: Johannes Schindelin
- Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- References:
- git bug: rebase fatal failure
- From: Tommy Thorn
- Re: git bug: rebase fatal failure
- From: Johannes Schindelin
- Re: git bug: rebase fatal failure
- From: Johannes Schindelin
- [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- From: Johannes Schindelin
- Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- From: Avery Pennarun
- Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- From: Johannes Schindelin
- Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- From: Avery Pennarun
- Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- From: Johannes Schindelin
- git bug: rebase fatal failure
- Prev by Date: Re: [PATCH 0/3] git-cvsserver: Add support for some binary files
- Next by Date: Re: [SQUASHED PATCH] Add support for GIT_CEILING_DIRECTORIES
- Previous by thread: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- Next by thread: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- Index(es):