Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
- Date: Wed, 21 May 2008 11:08:32 -0700
- From: Junio C Hamano <junio@xxxxxxxxx>
- Subject: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> The function fgets() has a big problem with NUL characters: it reads
> them, but nobody will know if the NUL comes from the file stream, or
> was appended at the end of the line.
>
> So implement a custom read_line() function.
Looking at what handle_body() does for TE_BASE64 and TE_QP cases, I have
to wonder if this is enough. The loop seems to stop at (*op == NUL) which
follows an old assumption that each line is terminated with NUL, not the
new assumption you introduced that each line's length is kept in local
variable len.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html