Re: [NON-TOY PATCH] git bisect: introduce 'fixed' and 'unfixed'
- Date: Tue, 24 Jun 2008 15:22:02 -0400 (EDT)
- From: Daniel Barkalow <barkalow@xxxxxxxxxxxx>
- Subject: Re: [NON-TOY PATCH] git bisect: introduce 'fixed' and 'unfixed'
On Tue, 24 Jun 2008, Jeff King wrote:
> On Tue, Jun 24, 2008 at 06:09:28PM +0100, Johannes Schindelin wrote:
>
> > And this is my first attempt at a proper patch for it.
> >
> > Now with documentation, and hopefully all places where the
> > user is being told about a "bad" commit.
>
> This looks reasonably sane to me. The only thing I can think of that
> we're missing is that "git bisect visualize" will still show the refs as
> "bisect/bad" and "bisect/good".
>
> To fix that, you'd have to ask people to start the bisect by saying "I
> am bisecting to find a fix, not a breakage." And then you could change
> the refnames and all of the messages as appropriate.
That would also be a good way of taking care of the problem where someone
gets distracted while running a slow test, forgets what they're looking
for, and marks the result as "bad" instead of "unfixed".
-Daniel
*This .sig left intentionally blank*
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html