Re: [PATCH] Ship sample hooks with .sample suffix
- Date: Wed, 25 Jun 2008 05:18:54 +0000
- From: Peter Baumann <waste.manager@xxxxxx>
- Subject: Re: [PATCH] Ship sample hooks with .sample suffix
On Tue, Jun 24, 2008 at 07:09:03PM -0700, Junio C Hamano wrote:
> We used to mark hooks we ship as samples by making them unexecutable, but
> some filesystems cannot tell what is executable and what is not.
>
> This makes it much more explicit. The hooks are suffixed with .sample
> (but now are made executable), so enabling it is still one step operation
> (instead of "chmod +x $hook", you would do "mv $hook.sample $hook") but
> now they won't get accidentally enabled on systems without executable bit.
>
Wouldn't it be better to name the hooks $hook.deactivated so its obvious
to anybody that they are not executed? Just my 2 cents.
-Peter
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html