Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.
- Date: Wed, 25 Jun 2008 00:45:48 -0700
- From: Eric Wong <normalperson@xxxxxxxx>
- Subject: Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.
Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Eric Wong <normalperson@xxxxxxxx> writes:
>
> > Wait, nevermind, this is for remotes, not remote *branches*.
> >
> > Umm... are underscores now allowed in git config files?
>
> In
>
> [foo "bar"] baz = value
>
> foo and baz must be config.c::iskeychar() (and baz must be isalpha()), but
> "bar" can be almost anything.
>
> Isn't "not underscore" coming from DNS hostname part restriction?
No, nothing to do with DNS hostnames in the remote names. I think I
just looked at remotes2config.sh one day and used it as a reference :x
It's late and I've had a rough few days, but shouldn't
sanitize_remote_name() just escape . and "? Right now it's converting
stuff to . which has me very confused...
--
Eric Wong (in need of sleep and sanity atm...)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html