Re: [PATCH] git-gui: Don't select the wrong file if the last listed file is staged.
- Date: Wed, 25 Jun 2008 16:57:02 -0400
- From: "Shawn O. Pearce" <spearce@xxxxxxxxxxx>
- Subject: Re: [PATCH] git-gui: Don't select the wrong file if the last listed file is staged.
Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote:
> Abhijit Menon-Sen schrieb:
> > Johannes Sixt noticed that if the last file in the list was staged, my
> > earlier patch would display the diff for the penultimate file, but show
> > the file _before_ that as being selected.
> >
> > This was due to my misunderstanding the lno argument to show_diff.
> >
> > This patch fixes the problem: lno is not decremented in the special case
> > to handle the last item in the list (though we still need to use $lno-1
> > to find the right path for the next diff).
>
> Thanks. It works here, too:
Thanks, both. Its in my tree.
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html