Re: [JGIT PATCH] Disambiguate "push not supported" from "repository not found"

["Shawn O. Pearce" <spearce@xxxxxxxxxxx>]

Marek Zawirski <marek.zawirski@xxxxxxxxx> wrote:
> Robin Rosenberg wrote:
>> fredagen den 29 augusti 2008 02.18.38 skrev Shawn O. Pearce:
>>> +				if (avail.isEmpty())
>>> +					throw noRepository();
>>>  				throw eof;
>>>  			}
>>>  @@ -185,6 +182,10 @@ else if (this instanceof FetchConnection)
>>>  		available(avail);
>>>  	}
>>>  +	protected TransportException noRepository() {
>>> +		return new NoRemoteRepositoryException(uri, "not found.");
>>> +	}
>>> +
>>
>> Why an extra method for instantiating the exception?
>
> Isn't it overrode in subclass - BasePackPushConnection?

Correct.  I introduced the method so the subclass can inject its
own implementation for the catch block.  But its required to give
back a TransportException so the catch block can throw it, as we
do not want the subclass to be able to continue at this point.

-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html