Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- Date: Fri, 29 Aug 2008 12:01:33 -0700
- From: Karl Chen <quarl@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
>>>>> On 2008-08-29 09:08 PDT, Junio C Hamano writes:
Junio> I do not see any strong reason why the single caller of
Junio> user_path() has to keep using the static allocation.
Junio> Would it help to reduce the complexity of your
Junio> expand_user_path() implementation, if we fixed the
Junio> caller along the lines of this patch (untested, but
Junio> just to illustrate the point)?
Yes, expand_user_path() would be much simpler, it would basically
be me original implementation except for returning NULL on error.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
- Follow-Ups:
- Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- From: Junio C Hamano
- Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- References:
- Re: [PATCH] Support "core.excludesfile = ~/.gitignore"
- From: Junio C Hamano
- Re: [PATCH] Support "core.excludesfile = ~/.gitignore"
- From: Jeff King
- Re: [PATCH] Support "core.excludesfile = ~/.gitignore"
- From: Junio C Hamano
- Re: [PATCH] Support "core.excludesfile = ~/.gitignore"
- From: Jeff King
- Re: [PATCH] Support "core.excludesfile = ~/.gitignore"
- From: Junio C Hamano
- [PATCH v2] Support "core.excludesfile = ~/.gitignore"
- From: Karl Chen
- Re: [PATCH v2] Support "core.excludesfile = ~/.gitignore"
- From: Jeff King
- Re: [PATCH v2] Support "core.excludesfile = ~/.gitignore"
- From: Karl Chen
- Re: [PATCH v2] Support "core.excludesfile = ~/.gitignore"
- From: Junio C Hamano
- [PATCH v3] Expand ~ and ~user in core.excludesfile, commit.template
- From: Karl Chen
- Re: [PATCH v3] Expand ~ and ~user in core.excludesfile, commit.template
- From: Jeff King
- Re: [PATCH v3] Expand ~ and ~user in core.excludesfile, commit.template
- From: Junio C Hamano
- [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- From: Karl Chen
- Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- From: Junio C Hamano
- Re: [PATCH] Support "core.excludesfile = ~/.gitignore"
- Prev by Date: Re: [RFC/PATCH 1/2] for-each-ref: add new format 'refbasename'
- Next by Date: Re: How to create a branch without any links to the others branches
- Previous by thread: Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- Next by thread: Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- Index(es):