Re: [PATCH] Need last-minute review for kdenetwork/filesharing patch

[Urs Wolfer <uwolfer@xxxxxxx>]

On Thursday 10 January 2008 22:03:36 Jan Schäfer wrote:
> Hi,
>
> filesharing in KDE 4.0 branch is currently nearly completely broken.
> It took me some time to fix it, so I need a last-minute review for this
> patch to get it into 4.0.
> The patch fixes at least two not filed crash-bugs and in addition
> fixes/ports the following bugs in the KDE 4.0 branch:
> Bug 139623, Bug 102401, Bugs 94828 and 137685 are partly fixed, and most
> importantly: Bug 137577 is fixed.
> The patch should not break any messages, though I am not 100% sure, because
> I had to change UI-files.
> As the patch is about 1 MB (most of it are ui-file changes, because of a
> port from ui3 to ui4), I did not attach it, but you can retrieve it from
> trunk, as I already committed it there:
>
> svn diff -r 759551:759552
>
> I hope someone finds the time to review the patch, as I really think it
> should make it into KDE 4.0.

I have already given Jan some short comments about this patch some time ago. 
Code-wise, it looks good, but I cannot test functionalities here...

If there are no string changes, I think it's ok to commit it to the 4.0 branch 
(I have already told that to you...)

Bye
urs

Attachment: signature.asc
Description: This is a digitally signed message part.

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<