Re: nsplugins patch (KDE4)

[Urs Wolfer <uwolfer@xxxxxxx>]

On Tuesday 29 April 2008 06:52:54 Sergey Saukh wrote:
> Ummm, it's perfectly clear now, that returning empty UserAgent string to
> flashplugin, when it executes "Initialize" is generally not a good idea,
> because it breaks any actions, which depend on browser actions (like open
> new url).
> But returning just "Gecko" instead do the trick.
>
> I think, that in "Initialize" phase, flashplugin checks in what environment
> it was run, i.e. if it was run from a browser and checks what type of
> browser is it.
> If there was no (or empty) UserAgent string, then it assumes that it was
> not launched from a browser window and disables any actions, which lead to
> opening urls, or whatever.
> If it receives string which contains "Gecko" (not "(like Gecko)" though -
> seems it doesn't like gecko in parenthesis) it assumes, that it runs in a
> native environment and doesn't make any calls to libXt upon destruction.
> If it receives any other UserAgent string, then it uses libXt (don't know
> why) and we end up with nspluginviewer crash, when "destroy" method of
> flashplugin tries to call "XtRemoveTimeout"...

Thanks for your investigation. :)

> So I see two ways out from this mess:
> 1. Hardcode to return "Gecko" from g_NPN_UserAgent, when NPP structure is
> not set (indicates that it was called by flashplugin from "Initialize"). 

I thinks this is okay as a temporary solution. As soon as Adobe "fixes" this 
issue, we can swith back to the current way (without faking the UA).

> 2. Make Adobe programmers to fix this issue in flashplugin itself.
Bye
urs

Attachment: signature.asc
Description: This is a digitally signed message part.

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<