Re: [PATCH] Make kslideshow.kss work again
- Date: Thu, 1 May 2008 14:05:33 +0200
- From: Oswald Buddenhagen <ossi@xxxxxxx>
- Subject: Re: [PATCH] Make kslideshow.kss work again
On Thu, May 01, 2008 at 01:42:06PM +0200, Arno wrote:
> It tried to paint outside a paintEvent. The attached patch fixes this.
>
good
> While at it, [...]
> While at it, [...]
>
i'm no particular fan of cumulative patches. please split the patch - it
seems to be quite simple in that case.
why do you use painter paths? seems pretty pointless to me.
either fix the drawPixmap blocks to properly line up again or entirely
remove the extra spaces. btw, you may want to fix the missing spaces
around operators in the lines you change anyway.
--
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<