Re: [PATCH] Make kslideshow.kss work again

[Arno <arno@xxxxxxxxxxxxx>]

Hello,

On Thursday 01 May 2008 14:05:33 Oswald Buddenhagen wrote:
> On Thu, May 01, 2008 at 01:42:06PM +0200, Arno wrote:
> > It tried to paint outside a paintEvent. The attached patch fixes this.
>
> good
>
> > While at it, [...]
> > While at it, [...]
>
> i'm no particular fan of cumulative patches. please split the patch - it
> seems to be quite simple in that case.
It is trivial. I could create one patch to make it work again, one for 
removing the bitBlt-calls and one for the new headers.

> why do you use painter paths? seems pretty pointless to me.
Hmm, for me it was the easiest way to make it work again. Seems it isn't the 
best way :) I have to admit, I'm not very experienced in this kind of 
Qt-programming. What is the right way to get rid of the painter paths? Please 
give me a hint in the right direction.

> either fix the drawPixmap blocks to properly line up again or entirely
> remove the extra spaces. btw, you may want to fix the missing spaces
> around operators in the lines you change anyway.
I didn't really pay attention to that, but I'll fix it.

-- 
Regards,

Arno.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<