kded4 crash: favicons

[Sergey Saukh <thelich@xxxxxxxxx>]

Hello,

While using konqueror, I've faced a annoynig problem - random kded4 crash. 
While investigating further I've found that it crashes because of 
kded_favicons module.

In function "slotKill" QList<KIO::Job *> is cleared using qDeleteAll. While 
it's said to be a 99% safe, I think that it is that 1% when this algorithm 
leads to random crashes, because using "while.. delete" construction 
eliminates this problem.


-- 
Best regards,
Sergey A Saukh

--- /usr/local/src/kde4/kdebase-4.0.72/apps/lib/konq/favicons/favicons.cpp.orig	2008-02-28 23:04:23.000000000 +0600
+++ /usr/local/src/kde4/kdebase-4.0.72/apps/lib/konq/favicons/favicons.cpp	2008-05-06 13:55:37.000000000 +0700
@@ -266,8 +266,8 @@
 
 void FavIconsModule::slotKill()
 {
-    qDeleteAll(d->killJobs);
-    d->killJobs.clear();
+    while ( ! d->killJobs.isEmpty() )
+	delete d->killJobs.takeFirst();
 }
 
 #include "favicons.moc"

Attachment: signature.asc
Description: This is a digitally signed message part.

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<