Re: [PATCH] remove crashing kdebug in kshortcutseditoritem.cpp

["Andreas Hartmetz" <ahartmetz@xxxxxxxxx>]

2008/5/8 Benoît Jacob <jacob@xxxxxxxxxxxxxxx>:
> Hi,
>
>  I encountered a crash (backtrace attached) while configuring KWin shortcuts,
>  which is caused by the destructor of KShortcutEditorItem calling undo() which
>  does a kDebug() accessing some data that apparently is no longer alive. This
>  kDebug() was added in r778112.
>
>  Attached is a trivial patch removing that kDebug(), hence fixing that crash.
>
>  Should I commit? I'm not too sure as that kDebug() in undo() seems quite
>  useful. Only when undo() is called from the destructor, does that kDebug()
>  cause a crash. Well, maybe I should just leave that to the persons who know
>  better that code.
>
Hmmm... mjansen refactored that code and made some modifications. An
unconditional undo() on close does not seem to be a good idea :/
Most of all I wonder which problem it is supposed to solve.
I remember a recent bug, for example in KWin's effects configuration,
where your changes will always be discarded. Or at least it looks so
in the GUI. Well, we can probably sort this out quickly now.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<