Re: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix

[Oliver Endriss <o.endriss@xxxxxx>]

Johannes Stezenbach wrote:
> On Mon, May 12, 2008 at 07:30:10PM +0200, Oliver Endriss wrote:
> > Ingo Molnar wrote:
> >> -     depends on DVB_AV7110 && !STANDALONE
> >> +     depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD
> 
> > If you set DVB_AV7110_FIRMWARE=y, the firmware file under
> > DVB_AV7110_FIRMWARE_FILE must exist...
> 
> The point of PREVENT_FIRMWARE_BUILD is to make build testing
> with "make randconfig" possible. I think you should ACK
> this patch, it doesn't have any downsides for users of
> this driver.

No. If randconfig deselects both STANDALONE and PREVENT_FIRMWARE_BUILD,
the same problem will happen again...

The problem is that randconfig does not know what to do (i.e. provide a
firmware file) when it selects DVB_AV7110_FIRMWARE=y.

The driver depends on STANDALONE, and that should be sufficient:
| CONFIG_STANDALONE:
|   Select this option if you don't have magic firmware for drivers that
|   need it.

while CONFIG_PREVENT_FIRMWARE_BUILD means:
| CONFIG_PREVENT_FIRMWARE_BUILD:
|   Say yes to avoid building firmware. Firmware is usually shipped
|   with the driver, and only when updating the firmware a rebuild
|   should be made.

Imho randconfig should always set STANDALONE=y.

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/