Re: [PATCH 18/18] flag parameters: check magic constants

[David Miller <davem@xxxxxxxxxxxxx>]

From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 12 May 2008 20:13:41 -0700

> On Tue, 6 May 2008 17:18:07 -0400 Ulrich Drepper <drepper@xxxxxxxxxx> wrote:
> 
> > --- a/net/socket.c
> > +++ b/net/socket.c
> > @@ -1219,6 +1219,13 @@ asmlinkage long sys_socket(int family, int type, int protocol)
> >  	struct socket *sock;
> >  	int flags;
> >  
> > +	/* Check the SOCK_* constants for consistency.  */
> > +	BUILD_BUG_ON(SOCK_CLOEXEC != O_CLOEXEC);
> > +	BUILD_BUG_ON(SOCK_NONBLOCK != O_NONBLOCK);
> > +	BUILD_BUG_ON((SOCK_MAX | SOCK_TYPE_MASK) != SOCK_TYPE_MASK);
> > +	BUILD_BUG_ON(SOCK_CLOEXEC & SOCK_TYPE_MASK);
> > +	BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);
> 
> The fifth assertion triggers with alpha allmodconfig.

Unfortunately, MIPS and PARISC look like they will as well :-/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/