Re: [patch 6/9] fuse: add export operations

[Miklos Szeredi <miklos@xxxxxxxxxx>]

> On Fri, May 09, 2008 at 03:40:30PM -0400, Christoph Hellwig wrote:
> > This is the same filehandle type XFS uses for 64bit inode filesystems
> > where the parent is not encoded.  I'll post a patch soon to move that
> > 64bit inode handling to common code.  I don't think it's a good idea
> > to delay your patch until that happens, but can you chose the fid
> > types to be the same as XFS does currently so that a conversion is
> > easily possible.  The fh_type should be 0x81 (fh type 1 order by 0x80
> > to imply it's 64bit inodes)
> > 
> > In case you want to look at that patch I'v uploaded the current
> > version at http://verein.lst.de/~hch/generic-64bit-inode-export
> 
> Actually that patch should be ready for submission, so if you want to
> use it (and it should help cleaning things up a bit) feel free to add
> it to the series.  I'll provide a proper description and sign-off in
> that case.

Yeah, it would help.

One suggestion I have for that patch: leave export_encode_fh() as is
(or just rename got generic_encode_fh()), and introduce a new
generic_encode64_fh().  One less magic boolean parameter to worry
about, and there's very little shared code between those two anyway.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/