Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
- Date: Wed, 14 May 2008 02:56:12 -0700
- From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
On Wed, 14 May 2008 11:51:17 +0200 Benjamin Thery <benjamin.thery@xxxxxxxx> wrote: > > uninlining sysfs_rename_dir() would be a sensible solution. > > It is inlined only when CONFIG_SYSFS=n. When sysfs is enabled > sysfs_rename_dir() is compiled from fs/sysfs/dir.c > > Uninlining it will require us to find an appropriate .c file to put it > in: we can't put it in fs/sysfs/dir.c. It is not built if CONFIG_SYSFS > is disabled. Well yes, that's the problem. I stuck it in lib/kobject.c but ugh. I guess we could make it a macro and quickly run away. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH] Fix kobject_rename and !CONFIG_SYSFS
- From: Eric W. Biederman
- Re: kobject: Fix kobject_rename and !CONFIG_SYSFS
- From: Greg KH
- Re: kobject: Fix kobject_rename and !CONFIG_SYSFS
- From: Eric W. Biederman
- Re: kobject: Fix kobject_rename and !CONFIG_SYSFS
- From: Benjamin Thery
- Re: kobject: Fix kobject_rename and !CONFIG_SYSFS
- From: Greg KH
- [PATCH] Fix kobject_rename and !CONFIG_SYSFS v2
- From: Eric W. Biederman
- Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v2
- From: Greg KH
- [PATCH] Fix kobject_rename and !CONFIG_SYSFS v3
- From: Eric W. Biederman
- Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v3
- From: Randy Dunlap
- [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
- From: Eric W. Biederman
- Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
- From: Andrew Morton
- Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
- From: Eric W. Biederman
- Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
- From: Andrew Morton
- Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
- From: Benjamin Thery
- [PATCH] Fix kobject_rename and !CONFIG_SYSFS
- Prev by Date: Re: m68k: main.c:(.init.text+0x730): undefined reference to `strlen'
- Next by Date: Re: Non-working snd-pcsp
- Previous by thread: Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4
- Next by thread: Re: kobject: Fix kobject_rename and !CONFIG_SYSFS
- Index(es):