Re: [patch 2.6.26-rc4-git] PM: boot time suspend selftest

[Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>]

On Thu, 29 May 2008 23:29:48 +0200
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:

> On Thursday, 29 of May 2008, David Brownell wrote:
> > On Thursday 29 May 2008, Rafael J. Wysocki wrote:
> > > Two questions:
> > > 
> > > 1) How is it related to the analogous patch in the Ingo's tree?
> > 
> > AFAIK -- just that it's an updated version.  Comments, some
> > code flow, but mostly having the "test_suspend=mode" parameter
> > default to "safe -- no testing" and allows the choice of modes.
> > 
> > 
> > > 2) Does it apply to the current linux-next?
> > 
> > No idea.
> 
> Could you check, please?  The previous version didn't.
> 

There's just one trivial reject against the PCI tree's
pm-introduce-new-top-level-suspend-and-hibernation-callbacks:

***************
*** 293,299 ****
  	if (suspend_ops->finish)
  		suspend_ops->finish();
   Resume_devices:
  	device_resume();
   Resume_console:
  	resume_console();
   Close:
--- 342,350 ----
  	if (suspend_ops->finish)
  		suspend_ops->finish();
   Resume_devices:
+ 	suspend_test_start();
  	device_resume();
+ 	suspend_test_finish("resume devices");
   Resume_console:
  	resume_console();
   Close:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/