Re: [linux-pm] [PATCH] add a printk_init variant storing format strings in __initdata

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Wed, 2008-06-04 at 09:59 +0100, David Woodhouse wrote:
> On Wed, 2008-06-04 at 01:16 -0700, Andrew Morton wrote:
> > We're going to want to be able to call printk_init() from modules. 
> > Please fix and test that, if we decide to proceed.
> 
> Can we fix that by making it an alias for printk in the module case?
> 
> The only reason we need it to be __init is so that we get the section
> warnings when you use it from non-init code, right? Won't we get the
> warning when non-init code refers to the string in initdata anyway?

In fact, wasn't the warning Andy showed such a warning?

>     WARNING: vmlinux.o(.text+0x3): Section mismatch in reference from the
>         function something() to the variable .init.data:__printk_init_fmt.31426
>     The function something() references
>     the variable __initdata __printk_init_fmt.31426.
>     This is often because something lacks a __initdata
>     annotation or the annotation of __printk_init_fmt.31426 is wrong.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part