[PATCH 34/39] Be more explicit in __put_user_x
- Date: Fri, 27 Jun 2008 18:34:41 -0300
- From: Glauber Costa <gcosta@xxxxxxxxxx>
- Subject: [PATCH 34/39] Be more explicit in __put_user_x
For both __put_user_x and __put_user_8 macros, pass the error
variable explicitly.
Signed-off-by: Glauber Costa <gcosta@xxxxxxxxxx>
---
include/asm-x86/uaccess_32.h | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/asm-x86/uaccess_32.h b/include/asm-x86/uaccess_32.h
index ebfe6b2..2c90673 100644
--- a/include/asm-x86/uaccess_32.h
+++ b/include/asm-x86/uaccess_32.h
@@ -31,11 +31,11 @@ extern void __put_user_2(void);
extern void __put_user_4(void);
extern void __put_user_8(void);
-#define __put_user_x(size, x, ptr) \
+#define __put_user_x(size, x, ptr, __ret_pu) \
asm volatile("call __put_user_" #size : "=a" (__ret_pu) \
:"0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")
-#define __put_user_8(x, ptr) \
+#define __put_user_8(x, ptr, __ret_pu) \
asm volatile("call __put_user_8" : "=a" (__ret_pu) \
: "A" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")
@@ -66,19 +66,19 @@ extern void __put_user_8(void);
__pu_val = x; \
switch (sizeof(*(ptr))) { \
case 1: \
- __put_user_x(1, __pu_val, ptr); \
+ __put_user_x(1, __pu_val, ptr, __ret_pu); \
break; \
case 2: \
- __put_user_x(2, __pu_val, ptr); \
+ __put_user_x(2, __pu_val, ptr, __ret_pu); \
break; \
case 4: \
- __put_user_x(4, __pu_val, ptr); \
+ __put_user_x(4, __pu_val, ptr, __ret_pu); \
break; \
case 8: \
- __put_user_8(__pu_val, ptr); \
+ __put_user_8(__pu_val, ptr, __ret_pu); \
break; \
default: \
- __put_user_x(X, __pu_val, ptr); \
+ __put_user_x(X, __pu_val, ptr, __ret_pu); \
break; \
} \
__ret_pu; \
--
1.5.5.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 35/39] turn __put_user_check directly into put_user.
- From: Glauber Costa
- [PATCH 35/39] turn __put_user_check directly into put_user.
- References:
- [PATCH 0/39] Merge files at x86/lib
- From: Glauber Costa
- [PATCH 01/39] Don't use size specifiers
- From: Glauber Costa
- [PATCH 02/39] provide delay loop for x86_64
- From: Glauber Costa
- [PATCH 03/39] use rdtscll in read_current_timer for i386.
- From: Glauber Costa
- [PATCH 04/39] explicitly use edx in const delay function.
- From: Glauber Costa
- [PATCH 05/39] integrate delay functions
- From: Glauber Costa
- [PATCH 06/39] use something common for both architectures
- From: Glauber Costa
- [PATCH 07/39] don't clobber r8 nor use rcx
- From: Glauber Costa
- [PATCH 08/39] don't use word-size specifiers
- From: Glauber Costa
- [PATCH 09/39] adapt x86_64 getuser functions
- From: Glauber Costa
- [PATCH 10/39] rename threadinfo to TI
- From: Glauber Costa
- [PATCH 11/39] Don't use word-size specifiers on getuser_64
- From: Glauber Costa
- [PATCH 12/39] introduce __ASM_REG macro
- From: Glauber Costa
- [PATCH 13/39] use _ASM_PTR instead of explicit word-size pointers
- From: Glauber Costa
- [PATCH 14/39] merge getuser asm functions
- From: Glauber Costa
- [PATCH 15/39] don't save ebx in putuser_32.S
- From: Glauber Costa
- [PATCH 16/39] user put_user_x instead of all variants.
- From: Glauber Costa
- [PATCH 17/39] clobber rbx in putuser_64.S
- From: Glauber Costa
- [PATCH 18/39] pass argument to putuser_64 functions in ax register.
- From: Glauber Costa
- [PATCH 19/39] change testing logic in putuser_64.S
- From: Glauber Costa
- [PATCH 20/39] replace function headers by macros
- From: Glauber Costa
- [PATCH 21/39] don't use word-size specifiers in putuser files
- From: Glauber Costa
- [PATCH 22/39] use macros from asm.h
- From: Glauber Costa
- [PATCH 23/39] merge putuser asm functions
- From: Glauber Costa
- [PATCH 24/39] commonize __range_not_ok
- From: Glauber Costa
- [PATCH 25/39] merge common parts of uaccess.
- From: Glauber Costa
- [PATCH 26/39] merge getuser
- From: Glauber Costa
- [PATCH 27/39] move __addr_ok to uaccess.h
- From: Glauber Costa
- [PATCH 28/39] use k modifier for 4-byte access.
- From: Glauber Costa
- [PATCH 29/39] mark x86_64 as having a working WP.
- From: Glauber Costa
- [PATCH 30/39] don't always use EFAULT on __put_user_size.
- From: Glauber Costa
- [PATCH 31/39] merge __put_user_asm and its user.
- From: Glauber Costa
- [PATCH 32/39] don't always use EFAULT on __get_user_size.
- From: Glauber Costa
- [PATCH 33/39] merge __get_user_asm and its users.
- From: Glauber Costa
- [PATCH 0/39] Merge files at x86/lib
- Prev by Date: [PATCH 37/39] move __get_user and __put_user into uaccess.h
- Next by Date: [PATCH 38/39] put movsl_mask into uaccess.h
- Previous by thread: [PATCH 33/39] merge __get_user_asm and its users.
- Next by thread: [PATCH 35/39] turn __put_user_check directly into put_user.
- Index(es):