Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts
- Date: Mon, 30 Jun 2008 04:15:15 -0700
- From: David Brownell <david-b@xxxxxxxxxxx>
- Subject: Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts
On Monday 30 June 2008, Stefan Becker wrote:
> It seems IRQF_SHARED | IRQF_DISABLED has already been discussed several
> times on LKML:
Given that, I'm surprised that nobody has added a warning that
prints when those two flags are both passed to request_irq().
The problems have been around for a long time, "tested" and known
to be broken. They'll never go away without nag messages nudging
developers to fix the problems.
> Alan: should I try to implement his choice (f) insteadn, i.e. drop
> IRQF_DISABLED from USB HCD interrupts and disable interrupts in
> usb_hcd_irq() instead?
That's the best solution for USB, given that IRQF_DISABLED isn't
going to do what it claims to do.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/