Re: [PATCH 15/39] don't save ebx in putuser_32.S
- Date: Mon, 30 Jun 2008 17:43:57 -0300
- From: Glauber Costa <gcosta@xxxxxxxxxx>
- Subject: Re: [PATCH 15/39] don't save ebx in putuser_32.S
Andi Kleen wrote:
Glauber Costa <gcosta@xxxxxxxxxx> writes:clobber it in the inline asm macros, and let the compiler do this for us.I would expect that definitely will cause code size regressions ... -Andi
Andi, Thanks for reviewing my patches.Although I agree with you, I think the reduced codesize is not enough a reason to keep code duplicated. If you can provide a version of it that is granted to reduce the code size for both i386 and x86_64, or even one that makes it minimal for x86_64 and yet, works with i386, fine.
Otherwise, I still think this is the best option. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/39] Merge files at x86/lib
- From: Glauber Costa
- [PATCH 01/39] Don't use size specifiers
- From: Glauber Costa
- [PATCH 02/39] provide delay loop for x86_64
- From: Glauber Costa
- [PATCH 03/39] use rdtscll in read_current_timer for i386.
- From: Glauber Costa
- [PATCH 04/39] explicitly use edx in const delay function.
- From: Glauber Costa
- [PATCH 05/39] integrate delay functions
- From: Glauber Costa
- [PATCH 06/39] use something common for both architectures
- From: Glauber Costa
- [PATCH 07/39] don't clobber r8 nor use rcx
- From: Glauber Costa
- [PATCH 08/39] don't use word-size specifiers
- From: Glauber Costa
- [PATCH 09/39] adapt x86_64 getuser functions
- From: Glauber Costa
- [PATCH 10/39] rename threadinfo to TI
- From: Glauber Costa
- [PATCH 11/39] Don't use word-size specifiers on getuser_64
- From: Glauber Costa
- [PATCH 12/39] introduce __ASM_REG macro
- From: Glauber Costa
- [PATCH 13/39] use _ASM_PTR instead of explicit word-size pointers
- From: Glauber Costa
- [PATCH 14/39] merge getuser asm functions
- From: Glauber Costa
- [PATCH 15/39] don't save ebx in putuser_32.S
- From: Glauber Costa
- Re: [PATCH 15/39] don't save ebx in putuser_32.S
- From: Andi Kleen
- [PATCH 0/39] Merge files at x86/lib
- Prev by Date: Re: pull request: wireless-2.6 2008-06-30
- Next by Date: RE: Why get_user_pages fails?
- Previous by thread: Re: [PATCH 15/39] don't save ebx in putuser_32.S
- Next by thread: Re: [PATCH 12/39] introduce __ASM_REG macro
- Index(es):