Re: [PATCH 17/39] clobber rbx in putuser_64.S
- Date: Mon, 30 Jun 2008 18:00:43 -0300
- From: Glauber Costa <gcosta@xxxxxxxxxx>
- Subject: Re: [PATCH 17/39] clobber rbx in putuser_64.S
Andi Kleen wrote:
Glauber Costa <gcosta@xxxxxxxxxx> writes:Instead of clobbering r8, clobber rbx, which is the i386 way.Note rbx is callee saved on 64bit, so using that one means the surrounding function always has to save explicitely. Not the case with r8. There's a reason it is the way it is. -Andi
Right. Thanks for pointing this out. However, r8 is not available for i386. We could use %ax, but it holds part of the data for the call itself.But for this case, I think we can come up with a macro that selects the appropriate register for each of them. Should be easy to do now that the code is merged.
Many thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 17/39] clobber rbx in putuser_64.S
- From: Andi Kleen
- Re: [PATCH 17/39] clobber rbx in putuser_64.S
- References:
- [PATCH 0/39] Merge files at x86/lib
- From: Glauber Costa
- [PATCH 02/39] provide delay loop for x86_64
- From: Glauber Costa
- [PATCH 03/39] use rdtscll in read_current_timer for i386.
- From: Glauber Costa
- [PATCH 04/39] explicitly use edx in const delay function.
- From: Glauber Costa
- [PATCH 05/39] integrate delay functions
- From: Glauber Costa
- [PATCH 06/39] use something common for both architectures
- From: Glauber Costa
- [PATCH 07/39] don't clobber r8 nor use rcx
- From: Glauber Costa
- [PATCH 08/39] don't use word-size specifiers
- From: Glauber Costa
- [PATCH 09/39] adapt x86_64 getuser functions
- From: Glauber Costa
- [PATCH 10/39] rename threadinfo to TI
- From: Glauber Costa
- [PATCH 11/39] Don't use word-size specifiers on getuser_64
- From: Glauber Costa
- [PATCH 12/39] introduce __ASM_REG macro
- From: Glauber Costa
- [PATCH 13/39] use _ASM_PTR instead of explicit word-size pointers
- From: Glauber Costa
- [PATCH 14/39] merge getuser asm functions
- From: Glauber Costa
- [PATCH 15/39] don't save ebx in putuser_32.S
- From: Glauber Costa
- [PATCH 16/39] user put_user_x instead of all variants.
- From: Glauber Costa
- [PATCH 17/39] clobber rbx in putuser_64.S
- From: Glauber Costa
- Re: [PATCH 17/39] clobber rbx in putuser_64.S
- From: Andi Kleen
- [PATCH 0/39] Merge files at x86/lib
- Prev by Date: Re: [Bug #10961] 2.6.26-rc: nfsd hangs for a few sec
- Next by Date: Re: [PATCH] ptrace GET/SET FPXREGS broken
- Previous by thread: Re: [PATCH 17/39] clobber rbx in putuser_64.S
- Next by thread: Re: [PATCH 17/39] clobber rbx in putuser_64.S
- Index(es):