RE: [PATCH 11/13] viafb: viafbdev.c, viafbdev.h
- Date: Tue, 1 Jul 2008 09:14:01 +0800
- From: <JosephChan@xxxxxxxxxx>
- Subject: RE: [PATCH 11/13] viafb: viafbdev.c, viafbdev.h
Jiri,
Thanks for your comments, I will let our engineers to check those items you mentioned.
BRs,
Joseph Chan
-----Original Message-----
From: Jiri Slaby [mailto:jirislaby@xxxxxxxxx]
Sent: Tuesday, July 01, 2008 3:56 AM
To: Joseph Chan
Cc: linux-fbdev-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx
Subject: Re: [PATCH 11/13] viafb: viafbdev.c, viafbdev.h
On 06/30/2008 09:46 AM, JosephChan@xxxxxxxxxx wrote:
> Initialization, remove and some other important functions of viafb.
>
> Signed-off-by: Joseph Chan <josephchan@xxxxxxxxxx>
>
> diff -Nur a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
> --- a/drivers/video/via/viafbdev.c 1970-01-01 08:00:00.000000000 +0800
> +++ b/drivers/video/via/viafbdev.c 2008-06-30 08:53:33.000000000 +0800
> @@ -0,0 +1,2659 @@
[...]
> +static int timer_on;
> +struct timer_list timer_for3D;
Well the timer is neither inited nor used... ?
N������y��X��ǧv��){.n�����{���X����ܨ}���Ơz�j:+v������Z+��zf���h���~�������w���?���&�)ߢf��y�m���a��� 0���