Re: [PATCH 1/4] security: filesystem capabilities bugfix1

[Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>]

grumbles.

On Thu, 26 Jun 2008 01:47:21 -0700
"Andrew G. Morgan" <morgan@xxxxxxxxxx> wrote:

> Subject: [PATCH 1/4] security: filesystem capabilities bugfix1

"bugfix1" is not exactly a high-quality description of this change. 
Please put more thought into the patch titles.  I cooked up something
randomly sensible-looking for these changes.

> Date: Thu, 26 Jun 2008 01:47:21 -0700
> User-Agent: Thunderbird 2.0.0.14 (X11/20080421)
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Bugfix for the fragile setuid fixup code in the case that filesystem
> capabilities are supported.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.6 (GNU/Linux)
> 
> iD8DBQFIY1eZ+bHCR3gb8jsRAgneAJ4jvnswg0+5Rkr69YFbFYXexK8vNQCgnAS7
> jF5ZqrBAAtU7RNVHia18ODk=
> =cOzB
> -----END PGP SIGNATURE-----

Would much prefer that the above gobbledygook not be there, please.  It
causes me to go through a spectacular number of manual steps to be able
to extricate the diff, and it makes it hard to reply to the diff when
commenting on it.

Plain old text/plain with an inlined patch is much more user-friendly.

And the PGP signing doesn't gain us anything because I'd cheerfully
apply a patch from a faked "Andrew Morgan" anyway.  I'd expect the
real Andrew Morgan to squawk when he sees me apply a patch which he
didn't send.

<clicks on attachments, right-clicks, does save-as to a temp file,
reads the temp file back in, does s/^/^> /g)

> +	if (!issecure(SECURE_NO_SETUID_FIXUP)) {
> +		(void) cap_set_effective(old_cap);
> +	}

The unneeded braces and void cast are not in the preferred style.  I
zapped them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/