Re: [Bug 11388] New: 2.6.27-rc3 warns about MTRR range; only 3 of 16gb of memory is usable

[Arjan van de Ven <arjan@xxxxxxxxxxxxx>]

On Fri, 22 Aug 2008 08:24:59 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> 
> > > +               if (tmp != mask_lo) {
> > > +                       WARN_ON("mtrr: your BIOS has set up an
> > > incorrect mask, fixing it up.\n");
> > 
> > can you change WARN_ON to WARN_ON_ONCE ?
> 
> the commit below does that. Note that the condition is 
> WARN_ON(condition) or WARN(string) - WARN_ON(string) will just print
> a kernel stack unconditionally. Unfortunately there's no WARN_ONCE(). 
> (Arjan?)

Andrew removed that from the patches as "unused" :-(
oh well easy to add back ;-)


-- 
If you want to reach me at my work email, use arjan@xxxxxxxxxxxxxxx
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/