Re: [MPlayer-dev-eng] RN5 authentication for rtsp

[Paul <myj@xxxxxxxx>]

On Wed, 26 Mar 2008, The Wanderer wrote:

> Date: Wed, 26 Mar 2008 20:05:04 -0400
> From: The Wanderer <inverseparadox@xxxxxxxxxxx>
> Reply-To: mplayer-dev-eng@xxxxxxxxxxxx
> To: mplayer-dev-eng@xxxxxxxxxxxx
> Subject: Re: [MPlayer-dev-eng] RN5 authentication for rtsp
> 
> Paul wrote:
>
>> On Wed, 26 Mar 2008, Nico Sabbi wrote:
>
>>> Il Wednesday 26 March 2008 19:40:38 Paul ha scritto:
>>>>
>>>> Here's an updated patch with some bound checking on strings and
>>>> proper gargabe collection. There are no cosmetic changes
>>>
>>> at a quick glance there are still cosmetics in the initial part of
>>> your patch
>>
>> I can't see it. The extra indentation is neccessary IMHO.
>
> The extra indentation is necessary, yes, but it makes it harder to tell
> which lines have actually changed and which lines have merely been
> reindented, and so makes it harder to review the patch (or see what has
> changed, later, when looking at the commit log). Because of that, the
> standard around these parts is that all such cosmetic changes must be
> made in separate patches, to be applied after the patch which makes the
> functional changes.

I now fully understand what was needed. Thankfully, Uoti helped me out by 
submitting the patch in the prefered way and it sure makes it easier to 
read.

Paul
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng