Re: [MPlayer-dev-eng] [PATCH]Disable liba52 and libmp3 for icc

[Diego Biurrun <diego@xxxxxxxxxx>]

On Wed, Mar 26, 2008 at 11:09:34PM +0200, Uoti Urpala wrote:
> On Wed, 2008-03-26 at 21:33 +0100, Carl Eugen Hoyos wrote:
> > Currently, icc can't compile the internal libraries liba52 and libmp3 
> > (with optimizations). Attached patch changes the default 
> > for both libraries from "enabled" to "autodetect" and disables the 
> > comilation for intel compilers.
> 
> This is only because of linking failures due to optimized-out variables
> right? Better would be to fix the asm, removing MANGLE and using asm
> arguments instead. At least for liba52 that shouldn't be too much work.
> MANGLE is only used in two files, imdct.c and resample_mmx.c, and I
> already created a patch removing MANGLE from imdct.c earlier when
> testing that the technique works.

Carl, if you could make these changes and they are backwards-compatible
then that is likely the best solution.  Otherwise feel free to apply
your patch.

Diego
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng