Re: [MPlayer-dev-eng] libvo changes

[Diego Biurrun <diego@xxxxxxxxxx>]

On Sun, Apr 06, 2008 at 07:28:15AM +0300, Uoti Urpala wrote:
> On Sun, 2008-04-06 at 05:36 +0200, Diego Biurrun wrote:
> > I dislike "clean up" as commit message as well.  It's far from specific
> > (enough) to be really useful.
> 
> Useful for what? It's meant to express that the commit changes some code
> to a better form with no noticeable functionality changes, and the
> details are not anything you'd normally consider interesting, useful or
> particularly tricky. What use would you have for specifics like "moves a
> misindented line 3 spaces to the right, removes a no-op x+=0; statement,
> splits a 200 character long line"?

I agree that this would be verbose, but I would not mind it.  The use I
would have for this is while looking through the log and searching for a
specific cosmetic change.  If you have multiple "clean up" messages,
this quickly becomes a problem.

> If you think "clean up" can be interpreted to mean something else (what?
> larger nontrivial changes?) and some other choice of words should be
> used then fair enough, but I don't really see what use more specifics
> would have.

My first association for "clean up" is refactoring; things like
moving common code into a function and similar things.

I would appreciate if you could replace the commit message with

"cosmetics: Rename a variable and change code formatting."

or something similar.

Diego
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng