Re: [MPlayer-dev-eng] [PATCH] Runtime colorful and/or module name output control

["Zuxy Meng" <zuxy.meng@xxxxxxxxx>]

2008/4/9, Diego Biurrun <diego@xxxxxxxxxx>:
> [...]
> > --- mp_msg.c  ?????? 26348??
> > +++ mp_msg.c  ????????????
> > @@ -30,6 +27,8 @@
> >  int verbose = 0;
> > +int mp_msg_color = 0;
> > +int mp_msg_mod = 0;
>
> Could you please call this mp_msg_module?
>
> > @@ -86,9 +85,92 @@
> > +static void print_msg_mod(FILE* stream, int mod)
>
> and print_msg_module here ..
>
> > +    static const char *mod_text[MSGT_MAX] = {
>
> module_text
>
> This would make things more readable IMO.

No problem. However I won't change the parameter name "mod" to
"module" so as to be consistent with other variables and parameters.
And I won't attach the patch again :-)

Will commit with the suggested changes this weekend if nobody objects.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng