Re: [MPlayer-dev-eng] [PATCH] add support of compression algorithm 3 in mkv demuxer

[Diego Biurrun <diego@xxxxxxxxxx>]

On Fri, May 09, 2008 at 01:37:46PM +0200, Aurelien Jacobs wrote:
> Diego Biurrun wrote:
> 
> > On Fri, May 09, 2008 at 01:48:35PM +0300, Ivan Kalvachev wrote:
> > > On Fri, May 9, 2008 at 1:22 PM, Aurelien Jacobs <aurel@xxxxxxxxxx>
> > > wrote:
> > > > Diego Biurrun wrote:
> > > >
> > > >> On Fri, May 09, 2008 at 04:19:55AM +0400, Evgeniy Stepanov wrote:
> > > >> > On Friday 09 May 2008 03:12:42 Aurelien Jacobs wrote:
> > > >> > > I'm sorry, but I've put on hold all my mplayer work
> > > >> > > (including patches review), until root finally take a
> > > >> > > decision about the "Uoti case". So please be patient.
> > > >> >
> > > >> > Does it mean that you are blocking all the work on demux_mkv
> > > >> > and anything else you maintain? If not, I could commit the
> > > >> > patch. I see nothing wrong with it.
> > > >>
> > > >> Careful, Aurelien is on the record for getting "angry" if you do
> > > >> so much as add a few consts to "his" code.
> > > >
> > > > Weren't you the one who stated he wants to avoid flames ?
> > > > So I will try to avoid flames, and just state it once and clearly,
> > > > for those who may have a doubt:
> > > >  I have nothing against one adding a few consts to "my" code, I
> > > > have never complained about this and I will never complain about
> > > > this.
> > >
> > > The commit in question is r26412. The problem with this commit is
> > > not that Uoti have added few consts, but that with the very same
> > > commit he indented the tables these consts belong.
> > > Mixing functional with cosmetic changes.
> > 
> > You should read Aurelien's message more closely.
> 
> I thought my original message was pretty clear. Here is the relevant
> quote:
>   BTW: you broke rules 6 and 9 in your recent commit to demux_mkv
>   (which I maintain). I was pretty hangry seeing this.
> If he didn't broke rule 6, I obviously wouldn't have complained about
> rule 9.

Nothing is as obvious from what you wrote as you seem to assume.  We
have plenty of precedents for adding consts all over.

Diego
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng