Re: [MPlayer-dev-eng] [PATCH] add support of compression algorithm 3 in mkv demuxer

[Reimar Döffinger <Reimar.Doeffinger@xxxxxxxxxxxxxxxxxxxxx>]

On Fri, May 09, 2008 at 01:49:09PM +0200, Diego Biurrun wrote:
> On Fri, May 09, 2008 at 01:37:46PM +0200, Aurelien Jacobs wrote:
> > I thought my original message was pretty clear. Here is the relevant
> > quote:
> >   BTW: you broke rules 6 and 9 in your recent commit to demux_mkv
> >   (which I maintain). I was pretty hangry seeing this.
> > If he didn't broke rule 6, I obviously wouldn't have complained about
> > rule 9.
> 
> Nothing is as obvious from what you wrote as you seem to assume.  We
> have plenty of precedents for adding consts all over.

Huh? What are you trying to say?? The "precedents" are at best for rule
9, but I am not ever sure about that, few well maintained areas needed
changes in that regard, also because after the first "frenzy" quite a
few maintainers checked their code themselves.
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng