Re: [MPlayer-dev-eng] [PATCH] fix v4l2 free_demuxer crash - uvcvideo

[Ötvös Attila <dc@xxxxxxxxx>]

Ezzel a dátummal: Friday 30 May 2008 13.28.33 Vladimir Voroshilov ezt írta:

Hi Vladimir Voroshilov!

>
> if (ioctl(priv->video_fd, VIDIOC_G_STD, &id) < 0) {
>    struct v4l2_streamparm      parm;
>
>    /* Here is comment why ioctl below is required bla-bla-bla */
>    parm.type=V4L2_BUF_TYPE_VIDEO_CAPTURE;
>    if(ioctl(priv->video_fd, VIDIOC_G_PARM, &parm) >= 0) {
>    {
>        mp_msg(MSGT_TV, MSGL_WARN, "%s: your device driver does not
> support VIDIOC_G_STD ioctl, VIDIOC_G_PARM was
>                  used instead.\n", info.short_name);
>        priv->standard.index=0;
>        priv->standard.id=0;
>        priv->standard.frameperiod=parm.parm.capture.timeperframe;
>        return 0;
>     }
>
>     mp_msg(MSGT_TV, MSGL_ERR, "%s: ioctl get standard failed: %s\n",
>            info.short_name, strerror(errno));
>     return -1;
> }
>
> And the rest of your patch is not needed.
>
> P.S. i didn't test code above.
> P.P.S i don't know how much "hackish" is either my or your solution.

I tested. It work.

Best regard.
Attila
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@xxxxxxxxxxxx
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng