[PATCH] repeating remote control keys on Compro VideoMate DVB-T300

[James Lawrence <james.lawrence@xxxxxxxxx>]

Hi all,

In my experience, the Compro VideoMate DVB-T300 remote control has a  
problem with inconsistent repeating keys on the remote control. The  
problem looks like this (note that key A and key B are any arbitrary  
keys on the remote):
press key A -> lirc recognizes key A
press key B -> lirc recognizes keys A, B
This makes it very hard to navigate through menus, rendering the  
remote control unusable.

This patch fixes this problem. I have tested this with two different  
TV cards, on 3 motherboards, with multiple distributions and on many  
kernel revisions from 2.6.15 to 2.6.23. The additional saa_clearb  
extends the width of the low pulse on SAA7134_GPIO_GPRESCAN.

[James@mythtv v4l-dvb]$ hg diff
diff -r 27b2c6a80826 linux/drivers/media/video/saa7134/saa7134-input.c
--- a/linux/drivers/media/video/saa7134/saa7134-input.c	Fri Nov 30  
18:27:26 2007 +0200
+++ b/linux/drivers/media/video/saa7134/saa7134-input.c	Sun Dec 02  
23:08:43 2007 +1100
@@ -76,6 +76,12 @@ static int build_key(struct saa7134_dev
 	}
 	/* rising SAA7134_GPIO_GPRESCAN reads the status */
 	saa_clearb(SAA7134_GPIO_GPMODE3,SAA7134_GPIO_GPRESCAN);
+	/* eliminate repeating keys issue on some boards*/
+	switch (dev->board) {
+	case SAA7134_BOARD_VIDEOMATE_DVBT_300:
+		saa_clearb(SAA7134_GPIO_GPMODE3,SAA7134_GPIO_GPRESCAN);
+		break;
+	}
 	saa_setb(SAA7134_GPIO_GPMODE3,SAA7134_GPIO_GPRESCAN);

 	gpio = saa_readl(SAA7134_GPIO_GPSTATUS0 >> 2);

Signed-off-by: James Lawrence <james.lawrence@xxxxxxxxx>

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list