Re: autosuspend for si470x

[Tobias Lorenz <tobias.lorenz@xxxxxxx>]

Hi Oliver,

> +	mutex_lock(&radio->lock);
> +	mutex_unlock(&radio->lock);

You are adding a lot of mutexes around si470x rds register accesses, which I don't think is necessary.
Parallel accesses to the registers will never harm anything or cannnot cause any data corruption.
I used radio->lock just for RDS buffer modifications, so multiple read/write attempts do not interfere.

But anyway, I applied anything else.
For testing it, I finally have to setup a kernel and environment, that support suspend and resume.
I try to give a feedback soon.

Bye,
  Toby

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list