Re: Two more patches required for soc_camera

[Guennadi Liakhovetski <g.liakhovetski@xxxxxxxxxxxxxx>]

On Fri, 8 Feb 2008, Mauro Carvalho Chehab wrote:

> On Fri, 8 Feb 2008 12:40:18 +0100 (CET)
> Guennadi Liakhovetski <g.liakhovetski@xxxxxxxxxxxxxx> wrote:
> > 
> > Ok, how about
> > 
> > 	depends on PCI || ARCH_PXA
> > 
> > ? I think, this way we are safe.
> 
> If you disable all things on arch/pxa, but v4l (and the minimum required
> dependencies), do it compile and work? If so, this would be ok. Otherwise, you
> may need something like:
> depends on PCI || (ARCH_PXA && CONFIG_HAS_DMA)
> 
> This approach can be an interim solution.

ARM never defines NO_DMA (see my email from yesterday), so, CONFIG_HAS_DMA 
would be redundant. And

#include <asm-generic/pci-dma-compat.h>

is the first line in include/arch-arm/pci.h, so, we are safe with this. 
However, to be 100% sure, I did what you suggested - switched off all I 
could in the config... and indeed videobuf-dma-sg.c refused to build. And 
you know which option it needs? CONFIG_BLOCK... But this must be a bug 
elswhere in the kbuild system. if CONFIG_BLOCK is off, the whole lib/lib.a 
doesn't get linked into vmlinux, although it does appear on the ld command 
line...

So, I would suggest that we just do (PCI || PXA) for now and I try to 
clarify the problem with the ARM people. What do you think?

> > If we do accept the above solution, would we still want to move to dma 
> > API?
> 
> I think so. The above approach is an workaround. It is not nice to have a
> non-pci thing including pci.h. Future patches may break the workaround.
> 
> > And would you like me to try to do this or you'd prefer to do this 
> > yourself?
> 
> Please do it and submit it to us, for testing.

Ok, I'll try to manage it before .26.

Thanks
Guennadi
---
Guennadi Liakhovetski

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list