Re: [v4l-dvb-maintainer] zoran: compilatation failure on ARM Orion

[Trent Piepho <xyzzy@xxxxxxxxxxxxx>]

On Thu, 14 Feb 2008, Lennert Buytenhek wrote:
> On Thu, Feb 14, 2008 at 01:59:30PM +0100, Martin Michlmayr wrote:
>
> > The zoran driver fails to compile on the ARM Orion platform with:
> >
> > In file included from drivers/media/video/zoran_procfs.c:50:
> > drivers/media/video/zoran.h:232: error: expected identifier before numeric constant
> >
> > The reason is that drivers/media/video/zoran.h defines an enum with
> > GPIO_MAX in it, but Orion contains a #define GPIO_MAX 32 in
> > include/asm-arm/arch-orion/orion.h
> >
> > I think it would be good if zoran.h would prefix these very generic
> > GPIO names with something.
>
> Not sure who is at fault here, as they're both playing in the same
> global namespace.  I guess we could patch either.

Not entirely the same namespace, as the arch header is included far more
often than the zoran.h header, which is only used by the zoran driver.  If
zoran uses GPIO_MAX, it's still possible for any other driver to use it
too.  Just as global function naming needs more namespace care than static
function naming, it seems like global arch headers should take more care
than local driver headers.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list