Re: OmniVision OV9655 camera chip via soc-camera interface

[Guennadi Liakhovetski <g.liakhovetski@xxxxxx>]

You forgot to cc the list, readded.

On Fri, 2 May 2008, Stefan Herbrechtsmeier wrote:

> Guennadi Liakhovetski schrieb:
> > 
> > 1. ATM these functions are called from the camera-host (pxa-camera) driver.
> > And until now it knew nothing about soc_camera_link. Which is also good.
> > 
> >    a) If we want to keep calls to these functions in the camera-host driver,
> > we'll either have to let it also handle soc_camera_link, or introduce some
> > parameter to these functions to tell the platform which camera shall be
> > resetted / powered on or off.
> > 
> >    b) Alternatively, we could call these functions from soc_camera_ops
> > init() and release() methods. Actually, I think, this would be the best
> > option.
> >   
> This means moving the init() and reset() functions into the soc_camera_link.
> Is this right?

Yes.

> > 2. Do you have a real-life example with several cameras on one interface?
> > ATM pxa_camera is explicitely limited to handle only one camera on its quick
> > capture interface. You would have to lift that restriction too.
> >   
> Not at the moment.
> 
> I have some addition suggestion for the soc_camera interface:
> 
> 1. Renaming SOCAM_HSYNC_* to SOCAM_HREF_*
> I think the current used Signal is HREF and not HSYNC.
> - HREF is active during valid pixels
> - HSYNC is a impulse at the start of each line before valid pixels and need
> some pixel skipping.
> 
> 2. Add a new SOCAM_HSYNC_* to the soc_camera interface
> 
> 3. Add x_skip_left to soc_camera_device
> The pxa_camera has to skip some pixel at the begin of each line if a HSYNC
> signal is used.
> (y_skip_top and x_skip_left can change with each format adjustment!)

How and why shall they change?

> 4. Remove camera_init() call before camera_probe()
> I think the driver should first detect the hardware before it do something
> with it.
> The first hardware initialization should be done in the probe function.

What camera_init do you mean? If you mean the ->add() call in 
soc_camera_open() then it is needed to activate the interface.

As usual, patches are welcome. When we see the code we can discuss it in 
detail.

Thanks
Guennadi
---
Guennadi Liakhovetski

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list