Re: [PATCH] Add x_skip_left to soc_camera_device

[Guennadi Liakhovetski <g.liakhovetski@xxxxxx>]

Hi Stefan,

On Fri, 16 May 2008, Stefan Herbrechtsmeier wrote:

> Sorry for the late answer, but I have to rework my driver.
> 
> Guennadi Liakhovetski schrieb:
> > I think, this is all we need for now - small and nice. Actually, it would
> > make even more sense to submit this when your new camera driver is ready,
> > but if you prefer, I'll accept it now. Just, please, resubmit it without the
> > above two hunks, and, maybe, add a sentence to the patch comment, saying
> > "will be used in xxx driver."
> >   
> Because of problems with the HSYNC support for different resolutions, I
> skipped it.
> I remove the HSYNC specific code (configuration of HSYNC or HREF) and
> only used HREF as signal. This makes this Patch obsolete for now.
> 
> Should I skip it or resubmit it for further use?

I think, reviewing and testing of patches is easier, if they either 1) fix 
bugs that can either be reproduced with currently supported 
configurations, or can be proven by studying the code; or 2) implement 
improvements, that can be verified with currently supported 
configurations; or 3) implement new features, that can be tested with 
currently or newly supported configurations. As you see, new features 
(x_skip_left support is a new feature), that cannot be tested are not in 
the above list:-)

So, I think, it would be easier for you and for reviewers, if you submit 
your new driver together with any necessary supporting modifications to 
the existing code, when you are reasonably happy with your results. 
Agree?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list